Add IP pool sidebar#3158
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
(We talked through this, and are not going to stack sidebars) |
david-crespo
reviewed
Jun 3, 2026
| const { queryKey } = q(api.ipPoolView, { | ||
| path: { pool: pool.id }, | ||
| }) | ||
| queryClient.setQueryData(queryKey, pool) |
Collaborator
There was a problem hiding this comment.
The robot noticed this pre-existing bug: the point of this is to pre-cache the data for the IP pool cells, but it doesn't work because the IP pool cells use the errors-allowed query, which has a different query key. I confirmed that fixing this eliminates the loading state from the cells.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a button to IP Pool Cells that opens up a sidebar with more info on the IP Pool.
I think it's a little strange that we have two different actions that both have the same UI — in one, we take the user to a new page, in the other, we open up this sidebar with more info. But if that's an issue, it's larger than this, as we already do both things in various points in the UI. I think it's just more noticeable here because the two kinds of cells are right next to each other in the Floating IP table.
We had also discussed the possibility of stacking sidebars, where we would make this IP pool cell in the properties table into a link that would then open another sidebar on top of it. We decided that this would be too confusing, though, so did not implement this.
Closes #3143